zNPCTypePrawn by LSLees · Pull Request #611 · bfbbdecomp/bfbb

LSLees · 2025-10-12T20:57:49Z

television struct, most of parseini, few other small functions

github-actions · 2025-10-12T20:59:13Z

🆗 ✅

+4386 bytes
🆗 Bot Rating: Amazing contribution, you are the decomp GOAT 🐐

No Regressions 🎉

Progress: 27

📈 main/SB/Game/zNPCTypePrawn - .text +2292 bytes -> 24.57%
📈 main/SB/Game/zNPCTypePrawn - .rodata +1306 bytes -> 59.51%
📈 main/SB/Game/zNPCTypePrawn - .bss +628 bytes -> 58.70%
📈 main/SB/Game/zNPCTypePrawn - .data +10 bytes -> 57.32%
📈 main/SB/Game/zNPCTypePrawn - .text +56 bytes -> 20.87%
📈 main/SB/Game/zNPCTypePrawn - .sdata2 +94 bytes -> 66.45%
📈 main/SB/Game/zNPCTypePrawn - zNPCPrawn::ParseINI() +952 bytes -> 35.36%
📈 main/SB/Game/zNPCTypePrawn - @unnamed@zNPCTypePrawn_cpp@::tweak_group::register_tweaks(bool, xModelAssetParam*, unsigned int, const char*) +840 bytes -> 60.34%
📈 main/SB/Game/zNPCTypePrawn - @unnamed@zNPCTypePrawn_cpp@::television::create(int, int) +4 bytes -> 0.75%
📈 main/SB/Game/zNPCTypePrawn - @unnamed@zNPCTypePrawn_cpp@::television::update(xModelInstance&, xLightKit*) +4 bytes -> 1.33%
📈 main/SB/Game/zNPCTypePrawn - @unnamed@zNPCTypePrawn_cpp@::init_sound() +4 bytes -> 1.47%
📈 main/SB/Game/zNPCTypePrawn - @unnamed@zNPCTypePrawn_cpp@::television::render_background() +40 bytes -> 16.67%
📈 main/SB/Game/zNPCTypePrawn - zNPCPrawn::Init(xEntAsset*) +148 bytes -> 78.72%
📈 main/SB/Game/zNPCTypePrawn - @unnamed@zNPCTypePrawn_cpp@::television::destroy() +4 bytes -> 2.27%
📈 main/SB/Game/zNPCTypePrawn - @unnamed@zNPCTypePrawn_cpp@::television::set_model_texture(xModelInstance&) +4 bytes -> 2.78%
📈 main/SB/Game/zNPCTypePrawn - @unnamed@zNPCTypePrawn_cpp@::television::move(const xVec3&, const xVec3&) +16 bytes -> 11.76%
✅ main/SB/Game/zNPCTypePrawn - aqua_beam::load(const aqua_beam::config&, unsigned int) +84 bytes -> 100.00%
📈 main/SB/Game/zNPCTypePrawn - aqua_beam::load(const aqua_beam::config&, RpAtomic&) +4 bytes -> 7.14%
✅ main/SB/Game/zNPCTypePrawn - @unnamed@zNPCTypePrawn_cpp@::tweak_group::load(xModelAssetParam*, unsigned int) +48 bytes -> 100.00%
✅ main/SB/Game/zNPCTypePrawn - @unnamed@zNPCTypePrawn_cpp@::television::set_vert(rwGameCube2DVertex&, float, float, float, float) +48 bytes -> 100.00%
✅ main/SB/Game/zNPCTypePrawn - @unnamed@zNPCTypePrawn_cpp@::television::set_background(iColor_tag) +44 bytes -> 100.00%
✅ main/SB/Game/zNPCTypePrawn - zNPCPrawn::Destroy() +44 bytes -> 100.00%
📈 main/SB/Game/zNPCTypePrawn - zNPCPrawn::IsAlive() +16 bytes -> 80.00%
✅ main/SB/Game/zNPCTypePrawn - zNPCPrawn::get_center() const +16 bytes -> 100.00%
✅ main/SB/Game/zNPCTypePrawn - zNPCPrawn::get_facing() const +16 bytes -> 100.00%
✅ main/SB/Game/zNPCTypePrawn - zNPCPrawn::ColChkFlags() const +8 bytes -> 100.00%
✅ main/SB/Game/zNPCTypePrawn - @unnamed@zNPCTypePrawn_cpp@::television::render_static() +4 bytes -> 100.00%

src/SB/Game/zNPCTypePrawn.cpp

github-actions · 2025-10-13T15:17:57Z

⚠️ 🔥

+4406 bytes
🆗 Bot Rating: Amazing contribution, you are the decomp GOAT 🐐

Regressions: 7

⚠️ main/SB/Core/gc/iCollide - .text -1632 bytes -> 65.17%
⚠️ main/SB/Core/gc/iCollide - iSphereHitsModel3(const xSphere*, const xModelInstance*, xCollis*, unsigned char, float) -203 bytes -> 70.00%
⚠️ main/SB/Core/gc/iCollide - iRayHitsEnv(const xRay3*, const xEnv*, xCollis*) -436 bytes -> 0.00%
⚠️ main/SB/Core/gc/iCollide - iRayHitsModel(const xRay3*, const xModelInstance*, xCollis*) -424 bytes -> 0.00%
⚠️ main/SB/Core/gc/iCollide - iSphereForModel(xSphere*, const xModelInstance*) -208 bytes -> 0.00%
⚠️ main/SB/Core/gc/iCollide - iBoxForModel(xBox*, const xModelInstance*) -88 bytes -> 0.00%
⚠️ main/SB/Core/gc/iCollide - iBoxForModelLocal(xBox*, const xModelInstance*) -272 bytes -> 0.00%

Progress: 27

📈 main/SB/Game/zNPCTypePrawn - .text +2292 bytes -> 24.57%
📈 main/SB/Game/zNPCTypePrawn - .rodata +1306 bytes -> 59.51%
📈 main/SB/Game/zNPCTypePrawn - .bss +648 bytes -> 60.25%
📈 main/SB/Game/zNPCTypePrawn - .data +10 bytes -> 57.32%
📈 main/SB/Game/zNPCTypePrawn - .text +56 bytes -> 20.87%
📈 main/SB/Game/zNPCTypePrawn - .sdata2 +94 bytes -> 66.45%
📈 main/SB/Game/zNPCTypePrawn - zNPCPrawn::ParseINI() +952 bytes -> 35.36%
📈 main/SB/Game/zNPCTypePrawn - @unnamed@zNPCTypePrawn_cpp@::tweak_group::register_tweaks(bool, xModelAssetParam*, unsigned int, const char*) +840 bytes -> 60.34%
📈 main/SB/Game/zNPCTypePrawn - @unnamed@zNPCTypePrawn_cpp@::television::create(int, int) +4 bytes -> 0.75%
📈 main/SB/Game/zNPCTypePrawn - @unnamed@zNPCTypePrawn_cpp@::television::update(xModelInstance&, xLightKit*) +4 bytes -> 1.33%
📈 main/SB/Game/zNPCTypePrawn - @unnamed@zNPCTypePrawn_cpp@::init_sound() +4 bytes -> 1.47%
📈 main/SB/Game/zNPCTypePrawn - @unnamed@zNPCTypePrawn_cpp@::television::render_background() +40 bytes -> 16.67%
📈 main/SB/Game/zNPCTypePrawn - zNPCPrawn::Init(xEntAsset*) +148 bytes -> 78.72%
📈 main/SB/Game/zNPCTypePrawn - @unnamed@zNPCTypePrawn_cpp@::television::destroy() +4 bytes -> 2.27%
📈 main/SB/Game/zNPCTypePrawn - @unnamed@zNPCTypePrawn_cpp@::television::set_model_texture(xModelInstance&) +4 bytes -> 2.78%
📈 main/SB/Game/zNPCTypePrawn - @unnamed@zNPCTypePrawn_cpp@::television::move(const xVec3&, const xVec3&) +16 bytes -> 11.76%
✅ main/SB/Game/zNPCTypePrawn - aqua_beam::load(const aqua_beam::config&, unsigned int) +84 bytes -> 100.00%
📈 main/SB/Game/zNPCTypePrawn - aqua_beam::load(const aqua_beam::config&, RpAtomic&) +4 bytes -> 7.14%
✅ main/SB/Game/zNPCTypePrawn - @unnamed@zNPCTypePrawn_cpp@::tweak_group::load(xModelAssetParam*, unsigned int) +48 bytes -> 100.00%
✅ main/SB/Game/zNPCTypePrawn - @unnamed@zNPCTypePrawn_cpp@::television::set_vert(rwGameCube2DVertex&, float, float, float, float) +48 bytes -> 100.00%
✅ main/SB/Game/zNPCTypePrawn - @unnamed@zNPCTypePrawn_cpp@::television::set_background(iColor_tag) +44 bytes -> 100.00%
✅ main/SB/Game/zNPCTypePrawn - zNPCPrawn::Destroy() +44 bytes -> 100.00%
📈 main/SB/Game/zNPCTypePrawn - zNPCPrawn::IsAlive() +16 bytes -> 80.00%
✅ main/SB/Game/zNPCTypePrawn - zNPCPrawn::get_center() const +16 bytes -> 100.00%
✅ main/SB/Game/zNPCTypePrawn - zNPCPrawn::get_facing() const +16 bytes -> 100.00%
✅ main/SB/Game/zNPCTypePrawn - zNPCPrawn::ColChkFlags() const +8 bytes -> 100.00%
✅ main/SB/Game/zNPCTypePrawn - @unnamed@zNPCTypePrawn_cpp@::television::render_static() +4 bytes -> 100.00%

github-actions · 2025-10-13T15:34:51Z

🆗 ✅

+4406 bytes
🆗 Bot Rating: Amazing contribution, you are the decomp GOAT 🐐

No Regressions 🎉

Progress: 27

📈 main/SB/Game/zNPCTypePrawn - .text +2292 bytes -> 24.57%
📈 main/SB/Game/zNPCTypePrawn - .rodata +1306 bytes -> 59.51%
📈 main/SB/Game/zNPCTypePrawn - .bss +648 bytes -> 60.25%
📈 main/SB/Game/zNPCTypePrawn - .data +10 bytes -> 57.32%
📈 main/SB/Game/zNPCTypePrawn - .text +56 bytes -> 20.87%
📈 main/SB/Game/zNPCTypePrawn - .sdata2 +94 bytes -> 66.45%
📈 main/SB/Game/zNPCTypePrawn - zNPCPrawn::ParseINI() +952 bytes -> 35.36%
📈 main/SB/Game/zNPCTypePrawn - @unnamed@zNPCTypePrawn_cpp@::tweak_group::register_tweaks(bool, xModelAssetParam*, unsigned int, const char*) +840 bytes -> 60.34%
📈 main/SB/Game/zNPCTypePrawn - @unnamed@zNPCTypePrawn_cpp@::television::create(int, int) +4 bytes -> 0.75%
📈 main/SB/Game/zNPCTypePrawn - @unnamed@zNPCTypePrawn_cpp@::television::update(xModelInstance&, xLightKit*) +4 bytes -> 1.33%
📈 main/SB/Game/zNPCTypePrawn - @unnamed@zNPCTypePrawn_cpp@::init_sound() +4 bytes -> 1.47%
📈 main/SB/Game/zNPCTypePrawn - @unnamed@zNPCTypePrawn_cpp@::television::render_background() +40 bytes -> 16.67%
📈 main/SB/Game/zNPCTypePrawn - zNPCPrawn::Init(xEntAsset*) +148 bytes -> 78.72%
📈 main/SB/Game/zNPCTypePrawn - @unnamed@zNPCTypePrawn_cpp@::television::destroy() +4 bytes -> 2.27%
📈 main/SB/Game/zNPCTypePrawn - @unnamed@zNPCTypePrawn_cpp@::television::set_model_texture(xModelInstance&) +4 bytes -> 2.78%
📈 main/SB/Game/zNPCTypePrawn - @unnamed@zNPCTypePrawn_cpp@::television::move(const xVec3&, const xVec3&) +16 bytes -> 11.76%
✅ main/SB/Game/zNPCTypePrawn - aqua_beam::load(const aqua_beam::config&, unsigned int) +84 bytes -> 100.00%
📈 main/SB/Game/zNPCTypePrawn - aqua_beam::load(const aqua_beam::config&, RpAtomic&) +4 bytes -> 7.14%
✅ main/SB/Game/zNPCTypePrawn - @unnamed@zNPCTypePrawn_cpp@::tweak_group::load(xModelAssetParam*, unsigned int) +48 bytes -> 100.00%
✅ main/SB/Game/zNPCTypePrawn - @unnamed@zNPCTypePrawn_cpp@::television::set_vert(rwGameCube2DVertex&, float, float, float, float) +48 bytes -> 100.00%
✅ main/SB/Game/zNPCTypePrawn - @unnamed@zNPCTypePrawn_cpp@::television::set_background(iColor_tag) +44 bytes -> 100.00%
✅ main/SB/Game/zNPCTypePrawn - zNPCPrawn::Destroy() +44 bytes -> 100.00%
📈 main/SB/Game/zNPCTypePrawn - zNPCPrawn::IsAlive() +16 bytes -> 80.00%
✅ main/SB/Game/zNPCTypePrawn - zNPCPrawn::get_center() const +16 bytes -> 100.00%
✅ main/SB/Game/zNPCTypePrawn - zNPCPrawn::get_facing() const +16 bytes -> 100.00%
✅ main/SB/Game/zNPCTypePrawn - zNPCPrawn::ColChkFlags() const +8 bytes -> 100.00%
✅ main/SB/Game/zNPCTypePrawn - @unnamed@zNPCTypePrawn_cpp@::television::render_static() +4 bytes -> 100.00%

github-actions · 2025-10-13T16:22:39Z

🆗 ✅

+4406 bytes
🆗 Bot Rating: Amazing contribution, you are the decomp GOAT 🐐

No Regressions 🎉

Progress: 27

📈 main/SB/Game/zNPCTypePrawn - .text +2292 bytes -> 24.57%
📈 main/SB/Game/zNPCTypePrawn - .rodata +1306 bytes -> 59.51%
📈 main/SB/Game/zNPCTypePrawn - .bss +648 bytes -> 60.25%
📈 main/SB/Game/zNPCTypePrawn - .data +10 bytes -> 57.32%
📈 main/SB/Game/zNPCTypePrawn - .text +56 bytes -> 20.87%
📈 main/SB/Game/zNPCTypePrawn - .sdata2 +94 bytes -> 66.45%
📈 main/SB/Game/zNPCTypePrawn - zNPCPrawn::ParseINI() +952 bytes -> 35.36%
📈 main/SB/Game/zNPCTypePrawn - @unnamed@zNPCTypePrawn_cpp@::tweak_group::register_tweaks(bool, xModelAssetParam*, unsigned int, const char*) +840 bytes -> 60.34%
📈 main/SB/Game/zNPCTypePrawn - @unnamed@zNPCTypePrawn_cpp@::television::create(int, int) +4 bytes -> 0.75%
📈 main/SB/Game/zNPCTypePrawn - @unnamed@zNPCTypePrawn_cpp@::television::update(xModelInstance&, xLightKit*) +4 bytes -> 1.33%
📈 main/SB/Game/zNPCTypePrawn - @unnamed@zNPCTypePrawn_cpp@::init_sound() +4 bytes -> 1.47%
📈 main/SB/Game/zNPCTypePrawn - @unnamed@zNPCTypePrawn_cpp@::television::render_background() +40 bytes -> 16.67%
📈 main/SB/Game/zNPCTypePrawn - zNPCPrawn::Init(xEntAsset*) +148 bytes -> 78.72%
📈 main/SB/Game/zNPCTypePrawn - @unnamed@zNPCTypePrawn_cpp@::television::destroy() +4 bytes -> 2.27%
📈 main/SB/Game/zNPCTypePrawn - @unnamed@zNPCTypePrawn_cpp@::television::set_model_texture(xModelInstance&) +4 bytes -> 2.78%
📈 main/SB/Game/zNPCTypePrawn - @unnamed@zNPCTypePrawn_cpp@::television::move(const xVec3&, const xVec3&) +16 bytes -> 11.76%
✅ main/SB/Game/zNPCTypePrawn - aqua_beam::load(const aqua_beam::config&, unsigned int) +84 bytes -> 100.00%
📈 main/SB/Game/zNPCTypePrawn - aqua_beam::load(const aqua_beam::config&, RpAtomic&) +4 bytes -> 7.14%
✅ main/SB/Game/zNPCTypePrawn - @unnamed@zNPCTypePrawn_cpp@::tweak_group::load(xModelAssetParam*, unsigned int) +48 bytes -> 100.00%
✅ main/SB/Game/zNPCTypePrawn - @unnamed@zNPCTypePrawn_cpp@::television::set_vert(rwGameCube2DVertex&, float, float, float, float) +48 bytes -> 100.00%
✅ main/SB/Game/zNPCTypePrawn - @unnamed@zNPCTypePrawn_cpp@::television::set_background(iColor_tag) +44 bytes -> 100.00%
✅ main/SB/Game/zNPCTypePrawn - zNPCPrawn::Destroy() +44 bytes -> 100.00%
📈 main/SB/Game/zNPCTypePrawn - zNPCPrawn::IsAlive() +16 bytes -> 80.00%
✅ main/SB/Game/zNPCTypePrawn - zNPCPrawn::get_center() const +16 bytes -> 100.00%
✅ main/SB/Game/zNPCTypePrawn - zNPCPrawn::get_facing() const +16 bytes -> 100.00%
✅ main/SB/Game/zNPCTypePrawn - zNPCPrawn::ColChkFlags() const +8 bytes -> 100.00%
✅ main/SB/Game/zNPCTypePrawn - @unnamed@zNPCTypePrawn_cpp@::television::render_static() +4 bytes -> 100.00%

JoshSanch

Thanks for the cleanup, LGTM!

LSLees and others added 7 commits October 8, 2025 19:43

Small ones

a47d26a

Television stuff

23f3d9d

Merge branch 'bfbbdecomp:main' into zNPCTypePrawn

c5c6760

Merge branch 'bfbbdecomp:main' into zNPCTypePrawn

1dd575e

parseini

3c90bb9

aqua load, init

6502af8

format

c687418

JoshSanch requested changes Oct 13, 2025

View reviewed changes

src/SB/Game/zNPCTypePrawn.cpp Outdated Show resolved Hide resolved

Fix closeup size

bf70025

Merge branch 'bfbbdecomp:main' into zNPCTPrawn

e87fdf1

:)

609f27c

JoshSanch approved these changes Oct 14, 2025

View reviewed changes

JoshSanch merged commit 8ff6a5f into bfbbdecomp:main Oct 14, 2025
5 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

zNPCTypePrawn#611

zNPCTypePrawn#611
JoshSanch merged 10 commits intobfbbdecomp:mainfrom
LSLees:zNPCTPrawn

LSLees commented Oct 12, 2025

Uh oh!

github-actions bot commented Oct 12, 2025

Uh oh!

Uh oh!

github-actions bot commented Oct 13, 2025

Uh oh!

github-actions bot commented Oct 13, 2025

Uh oh!

github-actions bot commented Oct 13, 2025

Uh oh!

JoshSanch left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

LSLees commented Oct 12, 2025

Uh oh!

github-actions bot commented Oct 12, 2025

🆗 ✅

No Regressions 🎉

Progress: 27

Uh oh!

Uh oh!

github-actions bot commented Oct 13, 2025

⚠️ 🔥

Regressions: 7

Progress: 27

Uh oh!

github-actions bot commented Oct 13, 2025

🆗 ✅

No Regressions 🎉

Progress: 27

Uh oh!

github-actions bot commented Oct 13, 2025

🆗 ✅

No Regressions 🎉

Progress: 27

Uh oh!

JoshSanch left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants